Update winit requirement from 0.29 to 0.30 #13254
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
the
C-Dependencies
|
I'm taking a stab at this update but I still need to figure some things out. I'll push a PR sometime this week if I have any success with it. |
|
@mnmaita I started taking a look, this will require a rewrite of most of the event loop. instead of one closure, Bevy now needs to pass a struct that implement a trait, and with a function by kind of event. it should be straightforward, but it will change a lot of lines. This will need to be validated on all platforms, and Android is currently completely broken, so that's not possible... You will also need to update access kit and access kit_winit at the same time. |
|
@mockersf thanks for the tip. What I'm wondering is if the trait has to be implemented for Regarding platforms I should be able to test it on most of them except MacOS and iOS, but I assume we can find volunteers to test in them. |
|
@Brezak or @pietrosophya could have opinions on that I think it should be renamed / merged with some of the other fields used for the event loop. Up to you if you prefer to keep it as close to how it currently is, or if you want to do that refactor at the same time |
|
|
We might want to hold of on this until the non- |
|
I wouldn't worry about it for now if this is coming soon. My target is to have something ready after 0.14 is released. |
|
Not to add pressure or anything, but after some investigation it seems Android support will be broken on Rust stable until Bevy is updated to winit 0.30 which brings android-activity 0.6 |
dependabot
bot
force-pushed
the
dependabot/cargo/winit-0.30
branch
from
35238e2 to
00f6457
Compare
Updates the requirements on [winit](https://github.com/rust-windowing/winit) to permit the latest version. - [Release notes](https://github.com/rust-windowing/winit/releases) - [Changelog](https://github.com/rust-windowing/winit/blob/master/CHANGELOG.md) - [Commits](rust-windowing/winit@v0.29.1-beta...v0.30.0) --- updated-dependencies: - dependency-name: winit dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/cargo/winit-0.30
branch
from
00f6457 to
e24a1fa
Compare
|
I created a draft PR here. |
|
Closing this one in favor of #13366 |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Updates the requirements on winit to permit the latest version.
Release notes
Sourced from winit's releases.
... (truncated)
Commits
4b3c065Winit version 0.30.00812adcAdd UIGestureRecognizerDelegate and PanGestureRecogniser (#3597)cd6ec19Don't set the background color when initializing with transparency (#3657)61bd817chore: fix some typos in comments (#3635)c04c113chore: ensure that.cargoconfig is not publishedce32a30android: bump tondk 0.9.0andandroid-activity 0.6.01682703bugfix(win32): Only return win handle on OK threadbdd80c8Add .git-blame-ignore-revs7b0c7b6chore(rustfmt): use nightly (#2325)7006c7cbugfix(android): AllowVolume*keys to be passed to the userDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)